This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
✨ Replace item icons with EmojiOne PNGs #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This workflow presents a list of emoji, so naturally the icon for each list item would be that emoji. Problem is, Alfred only supports files for this. What we can do is grab the pngs we need from EmojiOne. I'm having them written to the data directory, which seems better than just packaging them in the workflow?
The new gitmoji for "Adding or updating types" introduces a new case where the emoji being used decodes to a combination of \U and \u escaped codes (4 hex and 8 hex respectively), so the logic needs to improve in order to correctly resolve to the filename used by emojione-assets.
|
That looks good, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #2, by replacing the generic icon used for every workflow item with a PNG version of each item's specific emoji.
The image filenames are derived from the emoji's ASCII code, and then downloaded from the EmojiOne Assets repository. Each file will be downloaded a single time when the workflow first opens, and then saved to the workflow's data directory (i.e.
/Users/{name}/Library/Application Support/Alfred 3/Workflow Data/org.leolabs.alfred.gitmoji). The local files will continue to be reused as long as they exist there.Thanks!