-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework of SDC syntax definition for Issue #4 EOL Comments #5
Conversation
Removed the deprecated TextMate syntax style and setup the Sublime syntax variation.
Awesome @Remillard, thank you for your PR. I will review it later. |
Ah, just answering your items,
Cool, awesome.
Yes, it is.
Ok.
Good!
Ok, I agree with that. |
Those are probably in the base TCL syntax. I could try to override it maybe. The problem is that TCL is not really precise when it comes to token names. I'll see what I can do tomorrow. |
Yeah, I agree with you. I am almost about to merge your PR. So, if you can give it a try I will wait until the end of the week. We can also fix these things later. |
I've got to do some constraint work this afternoon so it'll be a perfect time to try to figure out if there's anything that can be done about the numeric constant issue. |
Oh, cool, that looks good. |
(?i)
and made the regular expression case-insensitive.{}
there are some guesses made by the Tcl syntax as to whether to scope the text inside a{}
as a string, or as a command block. Additionally, Tcl does not know all switches to all commands and largely doesn't try to figure it out, so the SDC switches (like-add_delay
) will be scoped in SDC mode, however regular Tcl switches will not be scoped. For the most part this doesn't matter unless writing really elaborate SDC files (I tested it with some automatically generated DDR SDC files and it did alright, though you'll start to see some weaknesses in the basic Tcl syntax.)