Material Scrim #275
Draft
Material Scrim #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the Material Design style, a scrim should be used any time the main application should lose focus for a child window. Since it should only apply to child windows, I've restricted what can create the scrim and what can't. The goal here is to eventually allow all children to force a scrim to be shown.
Additionally, this simplifies the necessity to create your own scrim in numerous places and allows library users to invoke the scrim themselves. For now, I've made it as simple as
Form.ShowScrim()andForm.HideScrim(). I want to additional features to it in the future, but work has been keeping me from committing much time to this library as I'd like.