New control MaterialExpansionPanel #143
Conversation
Introduce new control Expansion Panel (No animation implemented yet).
Add Expansion Panel Colors & Brushes
Add button enable property Chenge top padding Fix expand height issue in design mode Fix description bounds
remove extra blank line
Add MaterialExpansionPanel.cs
|
Nice work! , I'll review it tomorrow! |
Margin default value fix
There was a problem hiding this comment.
Please, see the review notes, most are just details and I'm nitpicking here. Overall, very good job!
Also, please add it on the example app, in the "Containers" tab (this is container.. right?)
And don't worry about adding animations on it for now, those are a pain to do on windows forms, specially if they make other components redraw (see drawer workaround mess I did). animation on the buttons would be nice tho.
| private const int _buttonPadding = 8; | ||
| private const int _expandcollapsbuttonsize = 24; | ||
| private const int _textHeaderHeight = 24; | ||
| private const int _headerHeightCollapse = 48; |
There was a problem hiding this comment.
_headerHeightCollapse and _headerHeightExpand should be the same. The way they are now, the header is "dancing around" when changing states, and that's a big no no.
There was a problem hiding this comment.
It might be only a misunderstanding due unappropriate constant name. Better name should be something like _controlHeightCollapse & _controlHeightExpand.
If not then please clarify a bit.
| private const int _expandcollapsbuttonsize = 24; | ||
| private const int _textHeaderHeight = 24; | ||
| private const int _headerHeightCollapse = 48; | ||
| private const int _headerHeightExpand = 64; |
There was a problem hiding this comment.
Also, I didn't verify this, but the component seems to have more padding then the other components, check the "padding and margins" values I use on other components, those should be constant trough the lib. I actually need to put them on a helper or something, but that's a refactor for another day, for now, just use the same values I do. I may just be crazy tho, so if I am wrong, just ignore this :P
Update following leocb review (thanks). Some conditions where missing before to fire events.
Use MaterialButton control for validation
Add Button minimum width management Fix ValidationButtonEnable default value
Fix Expand button color when disabled
|
Conflicts, they just keep on poping up huh |
Introduce Expansion Panel control (without animation).