Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Forgot some query options handling #19

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

jonas-martinez
Copy link
Contributor

@jonas-martinez jonas-martinez commented Feb 29, 2024

About this PR

Linked to #13

Technical highlight/advice

How to test my changes

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

@jonas-martinez jonas-martinez added the bug Something isn't working label Feb 29, 2024
@jonas-martinez jonas-martinez self-assigned this Feb 29, 2024
src/internal-api.yml Outdated Show resolved Hide resolved
@jonas-martinez jonas-martinez merged commit 0f8f208 into main Feb 29, 2024
1 check passed
@jonas-martinez jonas-martinez deleted the fix-handle-query-options branch February 29, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants