Skip to content

Commit

Permalink
Update test for needless-borrow FP for mutable ref
Browse files Browse the repository at this point in the history
  • Loading branch information
dswij committed Sep 13, 2021
1 parent a64b769 commit 6b4b77a
Showing 1 changed file with 16 additions and 8 deletions.
24 changes: 16 additions & 8 deletions tests/ui/needless_borrow.rs
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
// run-rustfix

#![allow(clippy::needless_borrowed_reference)]

fn x(y: &i32) -> i32 {
*y
}

#[warn(clippy::all, clippy::needless_borrow)]
#[allow(unused_variables)]
fn main() {
let a = 5;
let b = x(&a);
let c = x(&&a);
let _ = x(&a); // no warning
let _ = x(&&a); // warn

let mut b = 5;
mut_ref(&mut b); // no warning
mut_ref(&mut &mut b); // warn

let s = &String::from("hi");
let s_ident = f(&s); // should not error, because `&String` implements Copy, but `String` does not
let g_val = g(&Vec::new()); // should not error, because `&Vec<T>` derefs to `&[T]`
Expand All @@ -29,6 +28,15 @@ fn main() {
};
}

#[allow(clippy::needless_borrowed_reference)]
fn x(y: &i32) -> i32 {
*y
}

fn mut_ref(y: &mut i32) {
*y = 5;
}

fn f<T: Copy>(y: &T) -> T {
*y
}
Expand Down

0 comments on commit 6b4b77a

Please sign in to comment.