tcp: connect: Add source_address and bind_device options #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgraefe
force-pushed
the
tcp-connect-add-source-address
branch
from
c9e4b29 to
7fc14e0
Compare
kgraefe
changed the title
kgraefe
force-pushed
the
tcp-connect-add-source-address
branch
6 times, most recently
from
fac3e82 to
07fbb1d
Compare
lemunozm
reviewed
May 5, 2023
src/adapters/tcp.rs
Outdated
Comment on lines
40
to
41
| /// Bind the TCP connection to a specific interface, identified by its name. On other systems | ||
| /// this opion will be ignored. |
There was a problem hiding this comment.
Suggested change
| /// Bind the TCP connection to a specific interface, identified by its name. On other systems | |
| /// this opion will be ignored. | |
| /// Bind the TCP connection to a specific interface, identified by its name. | |
| /// This option works in Unix, on other systems, it will be ignored. |
There was a problem hiding this comment.
oh yes, I changed that sentence multiple times. At some point I must have dropped the Unix part accidentally .
Comment on lines
+135
to
+138
| #[cfg(unix)] | ||
| Err(e) if e.raw_os_error() != Some(libc::EINPROGRESS) => return Err(e), | ||
| #[cfg(windows)] | ||
| Err(e) if e.kind() != io::ErrorKind::WouldBlock => return Err(e), |
There was a problem hiding this comment.
Ask from the unknowledge, could a WouldBlock be obtained on Unix at this point (it seems like it's totally fine returning that for a socket implementation at this point)? In this case, an error will be returned when we shouldn't
There was a problem hiding this comment.
kgraefe
force-pushed
the
tcp-connect-add-source-address
branch
from
07fbb1d to
9f783b6
Compare
This option allows to specify the source address and port for outgoing TCP connections. Signed-off-by: Konrad Gräfe <[email protected]>
Add option to bind an outgoing TCP connection to a specific device, identified by its name. Signed-off-by: Konrad Gräfe <[email protected]>
kgraefe
force-pushed
the
tcp-connect-add-source-address
branch
from
9f783b6 to
41a9ef8
Compare
|
Thanks again for another awesome contribution! 🚀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows binding an outgoing TCP connection to a specific network interface. My use-case for that is that I need to support situations where two interfaces are configured for link-local addressing. In that case the system has two different routes into the link-local subnet.
On Windows the interface is determined by the IP address passed to
bind(). On Linux this is not sufficient as the routing table takes precedence. Therefore we must explicitly bind the socket to the interface.Depends on #153