udp: Add reuse_address and reuse_port options #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for spamming PRs ;-) it's just that I converted the adjustments I had hard-coded in my local fork onto the new API. |
kgraefe
force-pushed
the
udp-reuse-addr-and-port
branch
2 times, most recently
from
dea352b to
cb5c6a7
Compare
kgraefe
changed the title
lemunozm
requested changes
Mar 21, 2023
This change requires all UDP sockets (not just multicast sockets) to be created by socket2::Socket as mio::net::UdpSocket does not provide the set_reuse_address and set_reuse_port functions. Signed-off-by: Konrad Gräfe <[email protected]>
kgraefe
force-pushed
the
udp-reuse-addr-and-port
branch
from
cb5c6a7 to
957d02a
Compare
lemunozm
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change requires all UDP sockets (not just multicast sockets) to be created by socket2::Socket as mio::net::UdpSocket does not provide the set_reuse_address and set_reuse_port functions.