Skip to content

Commit

Permalink
NodeTask considered 'must_use' (#92)
Browse files Browse the repository at this point in the history
  • Loading branch information
lemunozm authored Jun 3, 2021
1 parent 54fe31b commit 73504d4
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 2 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## Release 0.14.1
- `NodeTask` is now considered *must_use*.

## Release 0.14.0
- Asynchronous connections: `NetworkController::connect()` behaviour modified.
Now it performs a non-blocking connection. Previous behaviour with `connect_sync` version.
Expand Down
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "message-io"
version = "0.14.0"
version = "0.14.1"
authors = ["lemunozm <[email protected]>"]
edition = "2018"
readme = "README.md"
Expand Down
1 change: 1 addition & 0 deletions src/node.rs
Original file line number Diff line number Diff line change
Expand Up @@ -496,6 +496,7 @@ impl<S: Send + 'static> Drop for NodeListener<S> {
/// The destruction of this entity will block until the task is finished.
/// If you want to "unblock" the thread that drops this entity call to
/// [`NodeHandler::stop()`] before or from another thread.
#[must_use = "The NodeTask must be used or the asynchronous task will be dropped in return"]
pub struct NodeTask {
network_thread: NamespacedThread<()>,
signal_thread: NamespacedThread<()>,
Expand Down

0 comments on commit 73504d4

Please sign in to comment.