-
Notifications
You must be signed in to change notification settings - Fork 229
Implement lemonade provider for Codex #1505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sawansri
wants to merge
11
commits into
main
Choose a base branch
from
sawansri/codex-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5c5b5b7
cli: replace codex --oss launch with provider config args
sawansri 2fc8fda
cli: add codex --use-user-config provider mode
sawansri 0b9e62a
cli: add launch --agent-args passthrough
sawansri c749790
remove OPENAI_BASE_URL
sawansri a55b7e9
disable analytics and feedback
sawansri 8570004
test: fix launch CLI tests
sawansri 137b9e1
cli: switch codex launch flag to --provider
sawansri 11d4064
remove all codex config reading/writing related code (user + codex ha…
sawansri c40b7fb
remove provider validation and clean up codex args
sawansri 14fff9d
add session resumption in docs
sawansri 6a01dfe
add Qwen 3.5 warnings for codex users and don't show in recommended m…
sawansri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
server log
Codex isnt working for me, any tips?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appears to be related to: ggml-org/llama.cpp#20733. There's a draft PR open to address this: ggml-org/llama.cpp#21174.
Looks like an upstream issue with the qwen3.5 model family. I've been testing with GLM 4.7 Flash and Nemotron 3 Nano, which probably explains why I haven't hit this issue.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll try again with GLM. Should Qwen3.5 not be a recommended recipe for Codex then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me with GLM! So yeah the recommended recipe list just needs to be adjusted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly, Qwen 3 Coder Next works fine for me, issue is mainly limited to the Qwen 3.5 family. Will remove them from the recommended list.
For those that have already downloaded Qwen 3.5 models, do you think we should add a warning for them as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added warnings for codex users