Fix composer.lock and composer.json inconsistency, add predis package for REDIS usage and limit PHP version > 7.2.0 due to new count() implementation #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9dbd043 changes zizaco/entrust version (lemberg#26) to fix issue 'This cache store does not support tagging' leaving composer.lock and composer.json in an incompatible state that arise an error when requiring new packages to the project. Signed-off-by: Lucas Picchi <[email protected]>
Signed-off-by: Lucas Picchi <[email protected]>
thefat32
changed the title
Since PHP 7.2 count() throws a warning in case a scalar or non-countable object is passed. "count(): Parameter must be an array or an object that implements Countable" error is being arised by some dependencies that did not document their incompatibility with 7.2 (i.e. laravel's framework \Illuminate\Database\Eloquent\Builder.php)
thefat32
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-9dbd0435109b3a0a6254387faf23123a79d275d8 changes zizaco/entrust version (#26) to fix issue 'This cache store does not support tagging' leaving composer.lock and composer.json in an incompatible state that arise an error when requiring new packages to the project.
-predis package needed for REDIS usage is missing from composer.json
-Since PHP 7.2 count() throws a warning in case a scalar or non-countable object is passed.
"count(): Parameter must be an array or an object that implements Countable" error is being arised by some dependencies that did not document their incompatibility with 7.2 (i.e. laravel's framework \Illuminate\Database\Eloquent\Builder.php)
Ref. https://wiki.php.net/rfc/counting_non_countables
Signed-off-by: Lucas Picchi [email protected]