Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dealing with slightly large files (>1MB), the reader loop becomes unnecessary slow. Increasing the buffer size from the default 10 to something larger substantially speeds up processing.
I understand the non-blocking API can be used to provide a custom buffer size, but I think it should be possible to do this for the blocking version too when the expected inputs safely fit in memory.
Also, any reason why the
read_buffer_size
values are different forparts
andreader
? Why not just have one default?