Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Workplace video call url regex #667

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

mullender
Copy link
Contributor

Status

READY

Description

This change makes the regex for workplace calls more specific. This prevents an issue where other workplace links (e.g. to posts, or notes) are picked up as the video call link.

I had tested this before using the custom regex setting in preferences. And that works fine, but does not show the workplace icon. Which is why I want to upstream the improved logic

Checklist

Steps to Test or Reproduce

Check with a meeting that contains a workplace video call link, and a workplace post link, observe that the VC link is extracted and not the post.

This change makes the regex for workplace calls more specific. This prevents an issue where other workplace links (e.g. to posts, or notes) are picked up as the video call link.

I had tested this before using the custom regex setting in preferences. And that works fine, but does not show the workplace icon. Which is why I want to upstream the improved logic
@GuyLewin
Copy link

Thank you @mullender ! Looking forward for this fix

@mullender
Copy link
Contributor Author

Test failed due to unrelated error: Unable to resolve action devbotsxyz/xcode-select, repository not found

@leits
Copy link
Owner

leits commented Nov 15, 2023

Thanks, @mullender!

@leits leits merged commit 6a45d6e into leits:master Nov 15, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants