Allows hiding past events #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Itaybre
reviewed
Sep 11, 2020
|
@Itaybre ah that seems to have slipped through indeed. I'll close this pr and open a new one. Thanks! |
|
oh, I realised I could just git rm the file. I believe it should be gone now. I've also removed the gitignore file I temporarily added. I hope this doesnt screw with the history too much! |
|
@dev10110 |
|
I don't mind! So some sort of drop down where you select either hide, cross out or allow joining? |
|
I think this feature has been on the review for too long. I'll think about improving UX separately. |
leits
approved these changes
Sep 21, 2020
|
my apologies for the delay :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Allows hiding events in the past, instead of just adding a checkmark to the side of the event.
Exposes an user-option to set this field, defaults to false to maintain past behaviour.