Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event start script bug #624

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Conversation

benbernard
Copy link
Contributor

Status

READY

Description

Found a bug with the event start script setting. It will only run if a join script is also setup, I think due to just a type in the accessing Defaults

Checklist

  • Localized (none required)
  • Added to changelog: (unclear to me if you want this given that I didn't want to make a whole version, happy to do what you want here)

Steps to Test or Reproduce

The bug happens if you have the run event script set but no join event. So Advanced settings looks like this:
image

In order for that to work, you have to have the join event location also set, which means you have to have that turned on. This fix changes to check the event start script location, which is what I believe was intended.

@leits
Copy link
Owner

leits commented Jun 7, 2023

Thank you!
Have you tested it?

@leits leits merged commit b605bd4 into leits:master Jun 7, 2023
@benbernard
Copy link
Contributor Author

I did test it! Thanks for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants