Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex for zoom webinars #619

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Fix regex for zoom webinars #619

merged 1 commit into from
Jun 7, 2023

Conversation

benbernard
Copy link
Contributor

Status

READY

Description

This change adds support for zoom webinars. These links take the form of:
https://company.zoom.us/webinar/register/WN_weEDiYboFZmW20t1GvD3JA

Checklist

Note happy to add a version change if you want me too, but wasn't clear to me that was desired

Steps to Test or Reproduce

  1. Create a meeting with a dummy webinar link in the notes (this is where these types of meetings normally have them)
  2. See that the zoom icon is associated in MeetingBar
  3. Click on meeting, see the link open in webbrowser

@benbernard
Copy link
Contributor Author

It wasn't clear to me how you would like the change log modified as its all organized into releases and doesn't seem to have an "upcoming releases" section to add to, happy to do what you want!

@leits leits self-assigned this Jun 7, 2023
@leits leits merged commit 2155881 into leits:master Jun 7, 2023
@leits
Copy link
Owner

leits commented Jun 7, 2023

Thank you, @benbernard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants