feat(events): allow to hide tentative events #515 #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allows to show, hide or mark tentative events as inactive. Tentative events are maybe events where the recipient do not know if he will attend.
|
@leits - do you think this is a good way to implement it? |
|
What do you think, @leits? |
|
@leits - what do you think? |
|
LGTM, sorry for the delay! |
leits
reviewed
Jun 26, 2023
|
|
||
| if shouldShowAsActive, Defaults[.showTentativeEvents] != TentativeEventsAppereance.show_underlined { | ||
| // add the NSTextAttachment wrapper to our full string, then add some more text. | ||
| styles[NSAttributedString.Key.font] = NSFont.boldSystemFont(ofSize: 14) |
|
Any news on this PR? This would dramatically boost the benefit of MeetingBar for my scenario. |
leits
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Checklist
Steps to Test or Reproduce