Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ellipsis at the end of the title of the statusItemMenu that opens the PreferenceWindow. #583

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

tokizuoh
Copy link
Contributor

@tokizuoh tokizuoh commented Feb 11, 2023

Status

READY

Description

Improve the user experience just a little by taking on board the following Human Interface Guidelines.

Append an ellipsis to a menu item’s label when people need to provide additional information before the action can complete.

https://developer.apple.com/design/human-interface-guidelines/components/menus-and-actions/menus

This is also applied to the official Sound and Bluetooth menu items, and I would like to reflect this in this application as well.

Checklist

Steps to Test or Reproduce

  1. Tap app icon on menu bar.
  2. "Preferences" ends with an ellipsis (...) is added to the end of "Preferences".

Screenshot 2023-02-11 at 15 32 03

Thanks for the great product. I use it often in my daily life.

@leits
Copy link
Owner

leits commented Mar 8, 2023

Thanks, @tokizuoh!

@tokizuoh
Copy link
Contributor Author

tokizuoh commented Mar 9, 2023

My pleasure :)

…ens the PreferenceWindow.

https://developer.apple.com/design/human-interface-guidelines/components/menus-and-actions/menus > 「Append an ellipsis to a menu item’s label when people need to provide additional information before the action can complete.」
@leits leits merged commit 5c01513 into leits:master Mar 9, 2023
@jaklan
Copy link
Contributor

jaklan commented Mar 11, 2023

Tbh ellipsis seems to be more relevant to options like Create meeting or Rate App - (Open) Preferences is completed when clicked and doesn't need any additional user input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants