Add support for pop meetings #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temikus
force-pushed
the
add_pop_support
branch
from
ca77084
to
6ed7004
Compare
|
Re-pushed as I made a small mistake in tests that was caught by the linter. |
|
I want to merge your pull request @Temikus - can you please fix the linting errors? Thx. |
I have detected that we have a problem with swiftformat that times out with a specific rule. So I will try to fix this in master first and update this branch afterwards. |
|
Oh man @jgoldhammer apologies, I think we collided a bit. Feel free to dismiss if my changes to changelog are not correct. |
jgoldhammer
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
This adds support for https://pop.com/ remote pairing software that we heavily use.
Checklist
Steps to Test or Reproduce
Simple unit test added but let me know if you need more.