forked from MetaMask/core
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ethereumjs util with metamask util #8
Open
legobeat
wants to merge
18
commits into
main
Choose a base branch
from
replace-ethereumjs-util-with-metamask-util
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legobeat
force-pushed
the
replace-ethereumjs-util-with-metamask-util
branch
6 times, most recently
from
February 19, 2024 02:58
d83f350
to
39e0c9f
Compare
legobeat
force-pushed
the
replace-ethereumjs-util-with-metamask-util
branch
2 times, most recently
from
February 21, 2024 10:41
ae073e6
to
e3aed79
Compare
lifted from assets-controller
TODO: see if safe to stop double-trimming leading as well as trailing zeroes in getTokenSymbol and thereby replace toUtf8 with something simpler.
…ls and @ethereumjs/util
…ask/utils and @ethereumjs/util
…tils and @ethereumjs/util
…util, ethereum-cryptography
…/utils equivalents
legobeat
force-pushed
the
replace-ethereumjs-util-with-metamask-util
branch
from
February 21, 2024 10:47
e3aed79
to
162d2d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
References
Changelog
@metamask/package-a
@metamask/package-b
Checklist