Skip to content

Commit

Permalink
ignore mismatching internal eth-json-rpc provider types
Browse files Browse the repository at this point in the history
  • Loading branch information
legobeat committed Oct 5, 2023
1 parent fb03fa2 commit bc269f5
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 9 deletions.
7 changes: 4 additions & 3 deletions packages/gas-fee-controller/src/GasFeeController.ts
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ export class GasFeeController extends PollingController<
this.legacyAPIEndpoint = legacyAPIEndpoint;
this.clientId = clientId;

this.ethQuery = new EthQuery(this.#getProvider());
this.ethQuery = new EthQuery(this.#getProvider() as any);

if (onNetworkStateChange && getChainId) {
this.currentChainId = getChainId();
Expand Down Expand Up @@ -417,7 +417,8 @@ export class GasFeeController extends PollingController<
isEIP1559Compatible = false;
}

const ethQuery = new EthQuery(networkClient.provider);
// TODO: provider type alignment
const ethQuery = new EthQuery(networkClient.provider as any);

const gasFeeCalculations = await determineGasFeeCalculations({
isEIP1559Compatible,
Expand Down Expand Up @@ -588,7 +589,7 @@ export class GasFeeController extends PollingController<
const newChainId = networkControllerState.providerConfig.chainId;

if (newChainId !== this.currentChainId) {
this.ethQuery = new EthQuery(this.#getProvider());
this.ethQuery = new EthQuery(this.#getProvider() as any);
await this.resetPolling();

this.currentChainId = newChainId;
Expand Down
6 changes: 4 additions & 2 deletions packages/network-controller/src/NetworkController.ts
Original file line number Diff line number Diff line change
Expand Up @@ -980,7 +980,8 @@ export class NetworkController extends BaseControllerV2<
}

const networkClient = this.getNetworkClientById(networkClientId);
const ethQuery = new EthQuery(networkClient.provider);
// TODO: Provider type alignment
const ethQuery = new EthQuery(networkClient.provider as any);

return new Promise((resolve, reject) => {
ethQuery.sendAsync(
Expand Down Expand Up @@ -1545,6 +1546,7 @@ export class NetworkController extends BaseControllerV2<
});
}

this.#ethQuery = new EthQuery(this.#providerProxy);
// TODO: Provider type alignment
this.#ethQuery = new EthQuery(this.#providerProxy as any);
}
}
6 changes: 4 additions & 2 deletions packages/network-controller/src/create-network-client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ export function createNetworkClient(
rpcUrl: networkConfig.rpcUrl,
});

const rpcProvider = providerFromMiddleware(rpcApiMiddleware);
// FIXME: types
const rpcProvider = providerFromMiddleware(rpcApiMiddleware as any);

const blockTrackerOpts =
// eslint-disable-next-line n/no-process-env
Expand All @@ -77,7 +78,8 @@ export function createNetworkClient(
: {};
const blockTracker = new PollingBlockTracker({
...blockTrackerOpts,
provider: rpcProvider,
// FIXME: types
provider: rpcProvider as any,
});

const networkMiddleware =
Expand Down
6 changes: 4 additions & 2 deletions packages/transaction-controller/src/TransactionController.ts
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,8 @@ export class TransactionController extends BaseController<
this.provider = provider;
this.messagingSystem = messenger;
this.getNetworkState = getNetworkState;
this.ethQuery = new EthQuery(provider);
// TODO: Provider type alignment
this.ethQuery = new EthQuery(provider as any);
this.isSendFlowHistoryDisabled = disableSendFlowHistory ?? false;
this.isHistoryDisabled = disableHistory ?? false;
this.registry = new MethodRegistry({ provider });
Expand Down Expand Up @@ -389,7 +390,8 @@ export class TransactionController extends BaseController<
);

onNetworkStateChange(() => {
this.ethQuery = new EthQuery(this.provider);
// TODO: Provider type alignment
this.ethQuery = new EthQuery(this.provider as any);
this.registry = new MethodRegistry({ provider: this.provider });
});

Expand Down

0 comments on commit bc269f5

Please sign in to comment.