Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Language: Korean (C / Python) #316

Open
wants to merge 1 commit into
base: korean-translation
Choose a base branch
from

Conversation

jehwison
Copy link

Make sure you go through the Contributing guide.

Please delete options that are not relevant.

Title

This pull request (PR) is made in reference to: #307

Description

What does this PR do?
This PR have Korean translation for C / python languages.

Recommendations for how to test this?
Made changes in Keywords for C and Python language in ./locale/ko.yml
You can see Korean translation of C language from line number 147 to 182.
Also you can see Korean translation of Python from line number 1247 to 1285.

Motivation and Context

This change have Korean translation for C / Python language.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@madiedgar madiedgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great @jehwison 👍🏾 Do you mind adding your github username and any commentary for why you chose a particular translation to help future reviewers? I've added a suggestion to help, but the translation guide will provide more details (see step 7 for emoji key).

Also, if you could include translations for the Python builtin functions in this PR that would be amazing! 😄 Thank you so much!

if: ""
static: ""
while: ""
auto: "자동"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
auto: "자동"
auto: "자동"
# ✅ @jehwison - (feel free to add any comments here, if desired)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants