cmake: Removes TINYXML2_EXPORT compile definition when building static library#805
Closed
wagcampbell wants to merge 1 commit intoleethomason:masterfrom
Closed
cmake: Removes TINYXML2_EXPORT compile definition when building static library#805wagcampbell wants to merge 1 commit intoleethomason:masterfrom
wagcampbell wants to merge 1 commit intoleethomason:masterfrom
Conversation
leethomason
changed the title
Owner
|
Please see #804. There are so many build PRs open I'm not sure the best approach to reconcile them. |
Contributor
|
@wagcampbell: Yes, exporting of symbols should be fixed, when building a static library. Could you please have a look at #820 too, if it would work for you? It contains a simple change to fix the issue. |
Author
Contributor
|
@leethomason This PR can be closed in favor of #820 |
Owner
|
Sounds good; closing this, merging #820 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request prevents symbols from being exported from a shared library that links with tinxyml2 when tinyxml2 is built as a static library. With this change, symbols will only be exported if tinyxml2 is built as a shared library. This also removes references to the BUILD_STATIC_LIBS CMake variable in the documentation as that variable is not used.
NOTE: This exclusively impacts Windows/MSVC platforms as the visibility rules with other platforms are different.