Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new category concurrency #42

Merged
merged 2 commits into from
Mar 12, 2020
Merged

Add new category concurrency #42

merged 2 commits into from
Mar 12, 2020

Conversation

xpunch
Copy link

@xpunch xpunch commented Mar 9, 2020

Some problems is in category concurrency, missing concurrency category will make some problems disappear in list commands.
You can try problem 1114, which is missing without concurrency.

Some problems is in category concurrency, missing concurrency category will make some problems disappear in list commands.
You can try problem 1114, which is missing without concurrency.
@jdneo
Copy link

jdneo commented Mar 11, 2020

Thank you @xpunch

Could you please try to fix the test? The code is here
https://github.com/leetcode-tools/leetcode-cli/blob/master/test/plugins/test_leetcode.js#L110-L129

Just Mock the request for concurrency as what it is for other categories, and change the length to 377 * 4

@xpunch
Copy link
Author

xpunch commented Mar 12, 2020

Hi @jdneo
I've added the codes that you commented.

Copy link

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @xpunch 👍

@jdneo jdneo merged commit 1cec0d5 into leetcode-tools:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants