Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor supervisor config #624

Merged
merged 4 commits into from
Dec 27, 2024

Conversation

leepeuker
Copy link
Owner

No description provided.

@leepeuker leepeuker requested a review from JVT038 December 19, 2024 11:26
@leepeuker
Copy link
Owner Author

@JVT038 I made a few adjustments extending your proposal. what do you think?

@leepeuker leepeuker changed the base branch from main to automatically-run-migrations December 19, 2024 11:28
@JVT038
Copy link
Collaborator

JVT038 commented Dec 20, 2024

I looked at your changes and they seem fine to me.

The only thing I'm concerned about is the order of the supervisor processes; If there's a job schedules which depends on a migration, then we have to make sure that the migration is ran before the job processor starts running.

I just pushed a commit which sets the priority and ensures that the migrations are executed before the jobs.

@leepeuker
Copy link
Owner Author

I looked at your changes and they seem fine to me.

The only thing I'm concerned about is the order of the supervisor processes; If there's a job schedules which depends on a migration, then we have to make sure that the migration is ran before the job processor starts running.

I just pushed a commit which sets the priority and ensures that the migrations are executed before the jobs.

hm, the priority only decides the order of starting the processes, so this does not really solve the issue in general, especially if the migrations takes a few seconds or longer. but I do not think we can solve this issue really via supervisor, this is not what supervisor was meant to do.

@JVT038
Copy link
Collaborator

JVT038 commented Dec 20, 2024

You might be right, but I'm pretty sure that if a job fails, the job will just be restarted 15 seconds later right? So we can also just keep it the way it is, and hopefully no issues regarding the process order will occur lol.

@JVT038
Copy link
Collaborator

JVT038 commented Dec 24, 2024

I think we should just YOLO merge this and we'll eventually find out if something is wrong lol

@leepeuker leepeuker merged commit fa06eed into automatically-run-migrations Dec 27, 2024
1 check passed
@leepeuker leepeuker deleted the refactor-supervisor-config branch December 27, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants