Add Plex OAuth #413
Add Plex OAuth #413
Conversation
|
BTW, I hope I did the dependency injection right, because I still don't really understand what dependency injection means or does, so I just tried some stuff until the errors disappeared lol. |
Refacotring and adjustments
Use url value objects in plex api
src/Api/Plex/PlexApi.php
Outdated
| try { | ||
| $plexAuthenticationData = $this->plexTvClient->sendPostRequest($relativeUrl); | ||
| } catch (PlexNoClientIdentifier) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
Why did you remove this?
There was a problem hiding this comment.
because I do not want to return null here, I always expect a authentication url from this method.
if this is not possible an exception should be thrown and the caller should decide what to do about it
| <input type="text" | ||
| name="plexServerUrlInput" | ||
| id="plexServerUrlInput" | ||
| class="form-control {% if plexTokenExists == false %} disabled {% endif %}" | ||
| value="{{ plexServerUrl }}" | ||
| aria-describedby="plexServerUrlInputPrefix" {% if plexTokenExists == false %} disabled {% endif %} | ||
| > |
There was a problem hiding this comment.
Honestly, I personally prefer to have all the HTML attributes on one line, regardless of how big this line may become.
There was a problem hiding this comment.
I enforce a 180 character limit per line via IDE, I much prefer scrolling vertically vs horizontally 😅
|
I see one open issue left, if |
|
Looks good to me. Screenshot: I think we should stay consistent with these things. Either use a question mark everywhere for help modals or the word 'help'. |
|
I aggree, I think I prefer the question mark, let's use this on the netflix page to? Maybe even together with the same button styling? |
This PR adds the ability for users to link their Plex account to Movary.
When the user logs in, the following happens:
X-Plex-Token, which gives Movary access to the user's data through the Plex API.This PR adds multiple columns:
plex_client_id: Necessary for the OAuth flow. It's the Plex identifier, so maybe we should change the column's name. This is provided by Plex after fetching anAuthentication URL.plex_client_temporary_code: As the name suggests, this is a temporary code that is fetched alongside with the Plex client ID / identifier. It will be valid for 15 minutes and during those 15min, it can be used to start a login process.plex_account_id: This is the ID o fthe Plex acount in the Plex system. This ID is necessary if you want to reach thehttps://plex.tvAPI, and not the local (http://localhost:32400) API. A lot of the API calls made to the central Plex API require the account ID, which is why it's stored in the database.plex_server_url: The server URL of the local Plex server. For some reason, some of the Plex API calls go to the local Plex server (mainly the data about the Plex server, such as which movies does the server have, which libraries, etc.), which is why this is stored in the database.When an user adds a local server, Movary will first check whether the user has access to the server. That's basically the only validation that currently exists.
When an users wants to 'log out', the values from the
plex_client_id,plex_client_temporary_code,plex_access_token, and theplex_account_idare deleted. (Actually, they're updated to the value ofnull).Feel free to leave any feedback and/or refactor my code; I haven't really changed it tbh; I just copied most of it from the old PR, changed it so that it doesn't cause errors and/or merge conflicts with the new code.
Question:
How will we validate the Plex server URL? It has to look like this
http://localhost:32400(especially the port is important). But it can also be like thishttps://plex.domain.comif the user is running a reverse proxy.