-
Notifications
You must be signed in to change notification settings - Fork 439
Chroma support (pruned Flux model) #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
f7ad456
Chroma: Initial commit (broken output)
stduhpf ad39011
Fix small mistake (still broken)
stduhpf 93ed721
is_chroma
stduhpf d20f77f
Reshape before approx
stduhpf bb1fe2c
format
stduhpf f506a63
Fix use_after_free (hopefully)
stduhpf 836fd72
Chroma: Attention masking (no pad)
stduhpf 67cc996
implement chroma mask padding
stduhpf 55a2686
Use env variable to control chroma padding settings
stduhpf 5a96b09
std::isinf
stduhpf 2bdc847
Use ggml_pad instead of concat with empty tensor
stduhpf 322fad2
Optimise masked attention
stduhpf 42e217d
Chroma: disable guidance by default
stduhpf 4fdedd5
Chroma: Fix t5 chunk length
stduhpf 3238fe3
fix mask with flash attn
Green-Sky efaa137
Remove deprecated Todos
stduhpf e22c57c
Only include pad into mask once
stduhpf 00141e5
Chroma/Pixart T5: Disable attention masking by default
stduhpf 60c2468
Merge branch 'master' into chroma
leejet 478992e
use parameters instead of environment variables
leejet 7e400c9
try to unify the code style
leejet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, now that I think of it. We should not pad with zeros, but with infs (or was it -inf).
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, -inf. (
-HUGE_VALFif I remember correctly)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that it matters too much, since we are not hitting this code path anyway.