-
Notifications
You must be signed in to change notification settings - Fork 58
Fix ser/deserialization for enums and Path #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Left a few minor comments
Co-authored-by: Fabrice Normandin <[email protected]>
… can be less representative
@lebrice thank you for the review!. I went through your comments and addressed them. I've also noticed that is better to use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I have noticed that by default
Enum
andPath
classes are not serialized/deserialized properly. This PR fixes the problem. It includes a few tests to check that it is working.