Skip to content

Conversation

ivanprado
Copy link
Contributor

I have noticed that by default Enum and Path classes are not serialized/deserialized properly. This PR fixes the problem. It includes a few tests to check that it is working.

Copy link
Owner

@lebrice lebrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Left a few minor comments

@ivanprado
Copy link
Contributor Author

@lebrice thank you for the review!. I went through your comments and addressed them.

I've also noticed that is better to use the Enum name instead of value: the latter may not be unique and can be less representative (e.g. if automatic integers are used as value). This change was implemented in 6296025

@ivanprado ivanprado requested a review from lebrice May 12, 2022 09:29
Copy link
Owner

@lebrice lebrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lebrice lebrice merged commit 121bc50 into lebrice:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants