Infra File Cleanup #5596
Infra File Cleanup #5596
Conversation
Does not appear to be used anywhere.
Doing as a single commit in case of ressurection.
DXCanas
force-pushed
the
studio-infra-file-cleanup
branch
from
cddc677 to
aae5494
Compare
| # Really seems like it _should_ be here, as it's referenced by `nginx.conf`. | ||
| # But it's hasn't been for years. | ||
| # COPY ${SRC_DIR}/mime.types /etc/nginx/mime.types |
…ndard. And deleting defunct cloudbuild prod yaml
Making a separate commit for bookmarking purposes. Seems we used to deploy to a separate/distinct dev cluster, and create new postgres instances for every single pr.
Standardizing on image-specific docker locations.
Will delete after both have been updated.
DXCanas
force-pushed
the
studio-infra-file-cleanup
branch
3 times, most recently
from
0de1409 to
0c39da8
Compare
|
It doesn't look it, but I did make sure to register file movements, renames, etc with git. In GH, the file history looks incomplete. But if you |
DXCanas
force-pushed
the
studio-infra-file-cleanup
branch
from
645e5a5 to
1394aba
Compare
rtibbles
left a comment
rtibbles
left a comment
There was a problem hiding this comment.
Reading through, I didn't see anything that alarmed me here, and checking out locally, the dev server still seems to work!
| skip_after_successful_duplicate: false | ||
| github_token: ${{ github.token }} | ||
| paths: '["k8s/images/nginx/*", ".github/workflows/containerbuild.yml"]' | ||
| paths: '["docker/Dockerfile.nginx.prod", "nginx/*", ".github/workflows/containerbuild.yml"]' |
There was a problem hiding this comment.
I think the second one "nginx/*" perhaps should have been "docker/nginx/*"?
There was a problem hiding this comment.
I… think maybe your right. Either that, or it was supposed to look at k8s/images/nginx/*, for the sake of the CD pipeline 🧐
The paths here were shuffled around multiple times and I think I got lost somewhere in that flurry 🙃
But this is the commit where it happened… so. idk. DXCanas@1dbd0db
Should I submit another PR to correct this? is it breaking build?
4 participants
Summary
Cleaning up infra-related files that no longer appear to be in use. Tried to bundle mass deletions by subject so we can go back for history.
Of Historical Note:
References
#5520
https://github.com/learningequality/infrastructure/issues/853
Reviewer guidance
It might be clearer to go commit-by-commit rather than seeing the full file changelog.
Really, I'm asking for y'all to make sure there are no breaking changes for the local dev workflow (I will deal with consequences to infra-side)