Autoconfig/set from member #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| AutoCurrentContext ctxt; | ||
| AutoRequired<MyConfigurableClass> mcc; | ||
|
|
||
| mcc->b = 10442; |
There was a problem hiding this comment.
MyConfigurableClass::b is an std::atomic, not an observable. The system is behaving as designed here.
There was a problem hiding this comment.
...except that it's crashing, I'll look into that.
yeswalrus
force-pushed
the
autoconfig/set-from-member
branch
from
41ee407 to
86d7bab
Compare
codemercenary
force-pushed
the
autoconfig/set-from-member
branch
from
44ccd8e to
86d7bab
Compare
Actually, the default value here will remain the default for objects not in the context.
Most of these test failures are fatal after the first violation, and successive violations don't actually tell us much. Use `ASSERT` instead where possible, and break up tests where `EXPECT` would have been useful.
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto config does not behave as expected when setting values directly from a field that is injected into a context.