Ref autoconfig autowired #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yeswalrus
commented
Mar 26, 2015
yeswalrus
commented
- Verify all code is following standard naming conventions.
- Complete Code Review
- Compress the commit history a bit
added 27 commits
March 25, 2015 13:56
…gManager from AutoConfig.h. Add some tests
… the same context.
…dCallback return a registration.
yeswalrus
force-pushed
the
ref-autoconfig-autowired
branch
from
51bd531 to
de245bf
Compare
| @@ -8,6 +8,7 @@ | |||
| #include FUNCTIONAL_HEADER | |||
| #include MEMORY_HEADER | |||
|
|
|||
| #include "AnySharedPointer.h" | |||
There was a problem hiding this comment.
Remove if not needed
| } | ||
|
|
||
| const std::unordered_map<std::string, const ConfigRegistryEntry*> AutoConfigListing::s_registry = FillRegistry(); | ||
| const std::unordered_map<std::string, AutoConfigListing::t_validator> AutoConfigListing::s_validators = FillValidators(); |
codemercenary
added a commit
that referenced
this pull request
Mar 27, 2015
Ref autoconfig autowired
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.