Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autoconfig #458

Merged
merged 7 commits into from
Mar 25, 2015
Merged

Fix autoconfig #458

merged 7 commits into from
Mar 25, 2015

Conversation

yeswalrus
Copy link
Contributor

Fixes several issues with autoconfig, adds three minor features & some additional unit tests.

@codemercenary
Copy link
Contributor

Add #include <stdexcept> to AutoConfigParser.cpp

@yeswalrus yeswalrus force-pushed the fix-autoconfig branch 2 times, most recently from 09ac892 to 9ab4310 Compare March 24, 2015 01:58
}
}

#if _WIN32 //Silence warnings about multiple default constructors on windows
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preprocessor macros are forbidden except where deprecation is intended or there is no other option. Must find another way to solve this problem.

codemercenary added a commit that referenced this pull request Mar 25, 2015
@codemercenary codemercenary merged commit 07a3692 into develop Mar 25, 2015
@codemercenary codemercenary deleted the fix-autoconfig branch March 25, 2015 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants