Deprecate ContextCreator #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemercenary
force-pushed
the
dep-contextcreator
branch
from
a29aad0 to
5557ccf
Compare
This type confusingly conflates the idea of context creation with context mapping. A separate type, ContextMap, already exists to function as a map between a key and a context, and should be preferred. Users should make use of `CoreContext::Create` or `AutoCreateContext` if they intend to create and manage a keyed set of contexts.
codemercenary
force-pushed
the
dep-contextcreator
branch
from
5557ccf to
1e2eb40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type confusingly conflates the idea of context creation with context mapping. A separate type, ContextMap, already exists to function as a map between a key and a context, and should be preferred. Users should make use of
CoreContext::CreateorAutoCreateContextif they intend to create and manage a keyed set of contexts.