Guarantee delayed event promotion. #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| latestTime | ||
| ); | ||
| } | ||
|
|
||
| void DispatchQueue::PromoteReadyEventsUnsafe(void) { |
There was a problem hiding this comment.
Change this return type to bool and have the return condition indicate whether any dispatchers were promoted. Also recommend a name change to PromoteReadyDispatchersUnsafe--you will need to keep the original name because it's now used in platform, just deprecate it.
|
This is a smart change, makes the |
codemercenary
force-pushed
the
ref-dispatchqueue
branch
2 times, most recently
from
7abad5d to
b0b6a19
Compare
codemercenary
force-pushed
the
ref-dispatchqueue
branch
from
b0b6a19 to
74d9e59
Compare
codemercenary
added a commit
that referenced
this pull request
Feb 13, 2015
Guarantee delayed event promotion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was easy to starve the delayedQueue when manually dispatching events