Refactoring AutoNetTransport concept #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better to have the transport in a separate file if it's a separate class. Also flipped a link that was making use of std::function in preference of an explicit interface, which seems to be more appropriate in this case.
codemercenary
force-pushed
the
ref-autonettransport
branch
from
ac3cca4 to
30936da
Compare
gtremper
added a commit
that referenced
this pull request
Feb 5, 2015
Refactor AutoNetTransport concept
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better to have the transport in a separate file if it's a separate class. Also flipped a link that was making use of std::function in preference of an explicit interface, which seems to be more appropriate in this case.