Remove AutoFuture code #1028
Merged
Remove AutoFuture code #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AutoFuture and
autowiring::then()appear to be an attempted implementation of continuations.This isn't really a deprecation of an existing feature because it's hardly working to begin with. There's an empty stub implementation of
autowiring::then()for Mac and not even a stub for Linux/Android.The unit test currently fails on Visual Studio 2017 and for reasons unknown fixing it will make it fail on Visual Studio 2013. By removing the test and associated code we can get AutowiringTest passing again.