Fix has_static_new #1013
Fix has_static_new #1013
Conversation
.gitignore
Outdated
| @@ -45,3 +45,5 @@ autowiring.kdev4 | |||
| autowiring.VC.db | |||
| .vscode | |||
| AutowiringVersion.h | |||
|
|
|||
| *.VC.db* | |||
There was a problem hiding this comment.
`Autowiring.VC.db is already listed above though?
Or if the intent here is the trailing asterisk, are there circumstances when it makes a db1, db2 file?
There was a problem hiding this comment.
Yeah, 2017 adds several extensions.
There was a problem hiding this comment.
I see now. I have Browse.VC.db and Solution.VC.db{,-shm,-wal}.
Should remove the now-redundant autowiring.VC.db above then?
|
|
||
| TEST_F(AutoConstructTest, MultiStaticNewTest) { | ||
| AutoConstruct<MultiStaticNew> badstatic{ 1 }; | ||
| } |
There was a problem hiding this comment.
This var is named badstatic. However, it looks like the good one?
src/autowiring/has_static_new.h
Outdated
| /// </summary> | ||
| /// <remarks> | ||
| /// A factory New routine is malformed when the return type is not implicitly castable to type T | ||
| /// </remarks> |
There was a problem hiding this comment.
Should keep the comments? I found the <remarks> line useful initially.
|
This implementation is effectively |
There was a problem hiding this comment.
I'm in agreement with @jdonald. Well done, @yeswalrus. If you can resolve @jdonald's remaining minor issues, this should be good to go.
| [**] | ||
| indent_style = space | ||
| indent_size = 2 | ||
| insert_final_newline = true |
There was a problem hiding this comment.
Ironic that this file is missing its final newline!
There was a problem hiding this comment.
Sadly, VS2017 has default support for editor config but ignores the 2 most useful options: insert_final_newline and trim_trailing_whitespace
MSVC2015, alone among MSVC versions and for reasons that are beyond me chokes on the function name detection portion of the old has_static_new's SFINAE.
This overhauls it to be far more concise, and compile correctly.