Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoreContext::Snoop is named backwards #469

Closed
vdods opened this issue Mar 26, 2015 · 1 comment
Closed

CoreContext::Snoop is named backwards #469

vdods opened this issue Mar 26, 2015 · 1 comment

Comments

@vdods
Copy link
Contributor

vdods commented Mar 26, 2015

E.g. if c is a context and s is an instance of a class with an AutoFilter method, then the call
c->Snoop(s)
looks like it should cause c to snoop s, but it really means s will snoop c. This is misleading.

@codemercenary
Copy link
Contributor

Agreed, this has been a long standing issue. I will rename this method to AddSnooper in order to improve clarity.

This method is extremely widely used, deprecation will take a month or two.

codemercenary added a commit that referenced this issue Mar 30, 2015
Fixes #469.  The Snoop method is misleading.  We cannot rename this method because it is too extensively used, but we can start a deprecation policy and get it fixed eventually.
codemercenary added a commit that referenced this issue Apr 2, 2015
Fixes #469.  The Snoop method is misleading.  We cannot rename this method because it is too extensively used, but we can start a deprecation policy and get it fixed eventually.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants