Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#69 ESLint v9 #76

Merged
merged 4 commits into from
Nov 4, 2024
Merged

#69 ESLint v9 #76

merged 4 commits into from
Nov 4, 2024

Conversation

mwarman
Copy link
Member

@mwarman mwarman commented Nov 4, 2024

📢 Instructions

  • Begin with a DRAFT pull request.
  • Follow italicized instructions to add detail to assist the reviewers.
  • After completing all checklist items, change the pull request to READY.

🔧 Change Summary

List the changes included in this pull request.

📝 Checklist

Pull request authors must complete the following tasks before marking the PR as ready to review.

  • Complete a self-review of changes
  • Unit tests have been created or updated
  • The code is free of [new] lint errors and warnings

🧪 Steps to Test

Describe the process to test the changes in this pull request.

  1. Code is free of lint errors and warnings.
  2. Regression test.

🔗 Additional Information

Optionally, provide additional details, screenshots, or URLs that may assist the reviewer.

  • It is possible that the React Hooks ESLint plugin is not fully compatible with the required ESLint flat config approach based upon some open issues in that project. While it does not fail when running ESLint, neither does it produce any errors or warnings when there are violations. It appears the next release will resolve this problem.

@mwarman mwarman added the dependencies Pull requests that update a dependency file label Nov 4, 2024
@mwarman mwarman self-assigned this Nov 4, 2024
@mwarman mwarman linked an issue Nov 4, 2024 that may be closed by this pull request
@mwarman mwarman marked this pull request as draft November 4, 2024 11:11
@mwarman mwarman marked this pull request as ready for review November 4, 2024 13:04
@mwarman mwarman merged commit ca3c26c into main Nov 4, 2024
4 checks passed
@mwarman mwarman deleted the 69-eslint-v9 branch November 4, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESLint v9
1 participant