Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While developing some widgets today I noticed that their state is no longer persisted when the cursor moves. The resulting re-mounting/reinitialization can be bad for performance, is jittery (see recordings), and makes it impossible for widgets to animate between adjacent states.
Persistence was broken in #500 with the addition of a
key
that resets the entireGoalInfoDisplay
component. This PR removes the key and reintroduces a state-clearing operation which is needed for correctness, but follows React docs so that there should hopefully not be any degradation in performance (I did not measure this, however). Note that setting state during rendering does technically result in a re-render, but it's a cheap one: the JSX that was returned in the first pass is never mounted or rendered.Before: https://github.com/user-attachments/assets/4ff9c1c4-ee92-4dd0-a401-987c3259f4ca
After: https://github.com/user-attachments/assets/6e5624d0-f256-4013-8381-86421b254ccf