Fix error message from cpack#803
Closed
lovettchris wants to merge 24 commits intoleanprover:masterfrom
lovettchris:clovett/cifix
Closed
Fix error message from cpack#803lovettchris wants to merge 24 commits intoleanprover:masterfrom lovettchris:clovett/cifix
lovettchris wants to merge 24 commits intoleanprover:masterfrom
lovettchris:clovett/cifix
Conversation
…dditional compile flag "-ftls-model=local-exec". I think cmake can easily do this just using target_compile_options.
Contributor
|
Thanks for your contribution! Please make sure to follow our Commit Convention. |
Member
Contributor
Author
|
If I go back to https://github.com/leanprover/lean4/actions/runs/1466228779 I see the error in the builds called "Linux", "Linux Debug", "Linux fsanitize", and "Windows", but for some reason not in "macOS" or the NIX based build named "Linux release"...
But I see your LLVM PR is disabling the Pack step? |
Contributor
Author
|
And on macOs I see this: so not sure why cpack doesn't complain on macOS but there is nothing matching "." there. which only leaves the NIX build which I don't have handy... |
Member
|
Resolved with #795 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.