Bundle clang+lld+libc++ for Windows#736
Closed
Kha wants to merge 30 commits intoleanprover:masterfrom
Closed
Conversation
dea52e1 to
5ce91d3
Compare
Member
Author
|
The size increase is more modest on Windows than on Linux: 110MB -> 150MB. This is presumably due to |
Member
Author
|
Uncompressed breakdown from CI: |
4b115e7 to
625066c
Compare
Member
|
@Kha why does the Windows distro bundle |
Member
Author
|
@tydeu I reported my guess on that above. But other than potential file size savings it really shouldn't matter. As I said in the Linux thread, this all should be regarded as implementation details. |
625066c to
bbe3697
Compare
cf6d832 to
ed2ca9a
Compare
Also, do so only for releases since `zstd -19` takes a while. Also, stop double-wrapping artifacts
ed2ca9a to
3f80452
Compare
b6dd5ea to
4dd67cb
Compare
4dd67cb to
bc2e2bd
Compare
Member
Author
|
Closing in favor of #795 |
ChrisHughes24
pushed a commit
to ChrisHughes24/lean4
that referenced
this pull request
Dec 2, 2022
Mathlib SHA: 71ca477041bcd6d7c745fe555dc49735c12944b7 Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com> Co-authored-by: Scott Morrison <scott@tqft.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on top of #733. There are no official LLVM tarball releases for Windows and we need the mingw headers anyway, so we simply copy everything from mingw.