feat: DiscrTree: index the domain of ∀
#5686
Draft
+54,733
−35,038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is an experiment. It bothered me that infering instances of the shape `Decidable (∀ (x : Fin _), _)` will go lineary through all instances of that shape, even those that are about `Fin Nat`. And that `Decidable (∃ (x : Fin _), _)` gets better indexing than `Decidable (∀ (x : Fin _), _)`. Judging from code commments, the discr tree used to index arrow types with two arguments (domain and body), and that led to bugs due to the dependency, so the arguments were removed. But it seems that indexing the domain is completely simple and innocent. So let’s see what happens.
github-actions
bot
added
the
changes-stage0
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 13, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 13, 2024
|
Mathlib CI status (docs):
|
leanprover-community-bot
added
the
breaks-mathlib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is an experiment.
It bothered me that infering instances of the shape
Decidable (∀ (x : Fin _), _)will go lineary through all instances of that shape, even those that are
about
Fin Nat. And thatDecidable (∃ (x : Fin _), _)gets betterindexing than
Decidable (∀ (x : Fin _), _).Judging from code commments, the discr tree used to index arrow types
with two arguments (domain and body), and that led to bugs due to the
dependency, so the arguments were removed. But it seems that indexing
the domain is completely simple and innocent.
So let’s see what happens.
This is just a small baby step compared to the more invasive improvements
done in the
RefinedDiscrTreeby J. W. Gerbscheid in mathlib.TODO: Update the comment around
.arrow.