fix: update nix files to use strings instead of URL literals#2172
Merged
Kha merged 1 commit intoleanprover:masterfrom Mar 28, 2023
Merged
fix: update nix files to use strings instead of URL literals#2172Kha merged 1 commit intoleanprover:masterfrom
Kha merged 1 commit intoleanprover:masterfrom
Conversation
Contributor
|
Thanks for your contribution! Please make sure to follow our Commit Convention. |
ConnorBaker
force-pushed
the
fix/nix-no-url-literals
branch
from
88389b6 to
a337779
Compare
ConnorBaker
force-pushed
the
fix/nix-no-url-literals
branch
from
a337779 to
0f6acbb
Compare
ConnorBaker
changed the title
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Kha
This PR changes URLs to strings by double-quoting them to move away from URL literals, which were deprecated by NixOS/rfcs#45.
Without this change, users with
no-url-literalsset to true are unable to create a flake from the template, or otherwise interact with the nix component of this repository.As always, thank you for the nix support :)