[Merged by Bors] - fix(frontends/lean/pp): correct binder links #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously these used the notation definition (the RHS of the `:=`) rather than the matched expression. This usually doesn't work at all, since often the RHS is just `#0` and all the notation happens within the `scoped` block.
eric-wieser
commented
Nov 14, 2022
| @@ -1,3 +1,6 @@ | |||
| pp_links.lean:10:32: error: tactic failed, there are unsolved goals | |||
| state: | |||
| ⊢ Exists∃ (i j : intℤ)Exists, truetrue | |||
There was a problem hiding this comment.
Previously this would print without any link on the ∃.
|
I don't see how this could've worked before. 👍 for adding the test now. bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 15, 2022
Previously these used the notation definition (the RHS of the `:=`) rather than the matched expression. This usually doesn't work at all, since often the RHS is just `#0` and all the notation happens within the `scoped` block. This affected a lot of mathlib notation; `Exists`/`infi`/`supr`/`filter.eventually`/`filter.frequently`/... I don't know if this used to work and then we broke it, or if it's always been broken.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously these used the notation definition (the RHS of the
:=) rather than the matched expression. This usually doesn't work at all, since often the RHS is just#0and all the notation happens within thescopedblock.This affected a lot of mathlib notation;
Exists/infi/supr/filter.eventually/filter.frequently/...I don't know if this used to work and then we broke it, or if it's always been broken.