Skip to content

fix: on-close event handler not be triggered on flutter >= 3.10 #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lijy91 merged 1 commit into from
Jul 1, 2023
Merged

fix: on-close event handler not be triggered on flutter >= 3.10 #343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions linux/window_manager_plugin.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1063,6 +1063,14 @@ void window_manager_plugin_register_with_registrar(
plugin->window_geometry.min_height = -1;
plugin->window_geometry.max_width = G_MAXINT;
plugin->window_geometry.max_height = G_MAXINT;

// Disconnect all delete-event handlers first in flutter 3.10.1, which causes delete_event not working.
// Issues from flutter/engine: https://github.com/flutter/engine/pull/40033
guint handler_id = g_signal_handler_find(get_window(plugin), G_SIGNAL_MATCH_DATA, 0, 0, NULL, NULL, fl_plugin_registrar_get_view(plugin->registrar));
if (handler_id > 0) {
g_signal_handler_disconnect(get_window(plugin), handler_id);
}

g_signal_connect(get_window(plugin), "delete_event",
G_CALLBACK(on_window_close), plugin);
g_signal_connect(get_window(plugin), "focus-in-event",
Expand Down