feat: add support for emitting events from winsparkle #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
sparkleEvents
property toautoUpdater
, which is aStream<String>
that a user can use to listen to callback events emitted by WinSparkle such asdidFindUpdate
ordidNotFindUpdate
.On the Windows side, callbacks are registered in
setFeedUrl
, because currently WinSparkle is only initialized after this is called.There might be a better way to handle the callbacks (without moving the channel pointer) but I'm no C++ expert, so this is the best solution I could come up with.
The events that can currently be emitted are:
error
shutdownRequest
didFindUpdate
didNotFindUpdate
updateCancelled
There is a different subset of events existing in the OSX implementation but these are the ones WinSparkle 0.7.0 supports.
If that's OK for you, I'd proceed with:
0.8.0