Skip to content
This repository has been archived by the owner on Oct 8, 2023. It is now read-only.

add Bootstrap 4 support #22

Closed
wants to merge 1 commit into from
Closed

add Bootstrap 4 support #22

wants to merge 1 commit into from

Conversation

hoaaah
Copy link

@hoaaah hoaaah commented May 31, 2021

No description provided.

@leandrogehlen
Copy link
Owner

leandrogehlen commented May 31, 2021

Thanks for PR.
I think this is not a good choice.
Maybe should better remove Bootstrap dependency and the developer can do this choice in your project

@hoaaah
Copy link
Author

hoaaah commented May 31, 2021

This PR is quick fix when you want to use BS4 instead of BS3 that comes with Yii2 by default. Of course this is an options to use BS4, if developer want to stick with BS3 they can easily ignore bsVersion params.

Without this PR, developer who wants to use BS4 can't use this extension because it keeps call BS3 Asset.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants