Create contacts_test.dart in example app
#968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
package: patrol
|
Android test fails until #967 is merged. iOS test gets stuck randomly during the flow. No error was thrown. The strange thing is that it gets stuck "in between" methods. Very strange, and very hard to debug. Occurs both on my physical iPhone 14 and on various iPhone simulators. Execution just stops. iOS.contacts.mp4 |
bartekpacia
added a commit
that referenced
this pull request
Mar 4, 2023
bartekpacia
added a commit
that referenced
this pull request
Mar 13, 2023
walid-ashik
reviewed
May 24, 2023
Comment on lines
+144
to
+147
| await $.native.tap(Selector(contentDescription: 'Create contact')); | ||
| await $.native.enterTextByIndex(firstName, index: 0); | ||
| await $.native.enterTextByIndex(lastName, index: 1); | ||
| await $.native.enterTextByIndex(company, index: 2); |
There was a problem hiding this comment.
This enterTextByIndex() can vary from device to device. Not all Android device's index: 2 has the company field. is there any better way we can ensure that index 2 has the company field across all the android devices?
Btw, it will be great to have this example 👍
There was a problem hiding this comment.
Unfortunately, it's not possible to make this test work on all Contacts app that exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To demonstrate complex native scenario.
This will serve as a good smoke test for Patrol's native automation feature.
Android
Android.contacts.mp4