Implement dynamic port selection for all platforms #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update environment variable names for test and app server ports - Remove hardcoded default ports in iOS and macOS - Modify port selection logic to use dynamic/free ports when not explicitly set - Update build configurations and CLI commands to support new port handling
Delete example script for preparing and uploading iOS test artifacts to Marathon Cloud
…earing permission
|
To view this pull requests documentation preview, visit the following URL: docs.page/leancodepl/patrol~2527 Documentation is deployed and generated using docs.page. |
github-actions
bot
added
package: patrol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the way selecting port for
PatrolServerandPatrolAppService.Previously, both were using globally defined default values if no value was passed using
test-server-portorapp-server-portflag. Now, if any of those flags will be not used, random free port will be used instead.Instrumentation and app under test will now exchange the information about which port is used. There is no need to define port in environment variables.
PR description will be continued...
One thing that remains unsolved is passing custom
test-server-porttopatrol build ioscommand. Needs to find a way to pass a value to instrumentation app while building the test runner